Repository navigation
Conversation
Log a warning when the GitLab interceptor processes a request without a secretRef, since the token is then not verified. Document the behavior for the GitLab and Bitbucket server interceptors. Fixes tektoncd#2030 Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2198 +/- ##
=======================================
Coverage 80.06% 80.07%
=======================================
Files 96 96
Lines 4645 4647 +2
=======================================
+ Hits 3719 3721 +2
Misses 667 667
Partials 259 259
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Changes
Part of #2030 (see the scope notes below)
The GitLab interceptor skips token verification when
secretRefis not set and accepts every request without any indication. As proposed in the issue, this logs a warning on each request processed without asecretRef, and the docs for the GitLab and Bitbucket server interceptors now say that omittingsecretRefdisables verification.Notes on scope:
secretRef, so it needs no change.Tests:
TestInterceptor_Process_WarnsWithoutSecretRefchecks that the warning is logged without asecretRefand not with one.go test ./pkg/interceptors/gitlab/passes./kind feature
Submitter Checklist
Release Notes